Remove extra nested dbus session
Needs ReviewPublic

Authored by davidedmundson on Feb 14 2019, 1:46 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

It's not needed if the systemd pam session is loaded. (or presumably CK2
equivalent)

We rely on this for kwin's logind integration anyway. Therefore the
extra nested session is pointless.
More importantly it will break should dbus-broker get used instead of
the classic dbus daemon.

BUG: 404335

Test Plan

Logged out and in
Still had DBus

Would be good if bshash can remember the reason he added it

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8289
Build 8307: arc lint + arc unit
davidedmundson created this revision.Feb 14 2019, 1:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2019, 1:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 14 2019, 1:46 PM
bshah added a subscriber: bshah.Feb 14 2019, 2:33 PM

Hmm, does git blame tell anything useful?

bshah added a comment.Feb 14 2019, 2:37 PM

git log says it is needed for systems where dbus-user-session is not installed

git log says it is needed for systems where dbus-user-session is not installed

Sure, but I don't understand why the solution is to work around it, rather than explain that it's a dep.


This is now causing me problems. I get the two user DBus's and they are set up differently. We need to do something.

IMHO we should just make socket activated DBus a system dependency for a working system.
Failing that I can turn this into a:

  • try and query DBus, if it fails, run this, otherwise do nothing.