Send axis_source, axis_discrete, and axis_stop
Needs ReviewPublic

Authored by zzag on Feb 14 2019, 11:06 AM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

So far KWin didn't send axis_source, axis_discrete, and axis_stop. Even
though most of those events are optional, clients need them to work as
expected. For example, one needs axis_source and axis_stop to implement
kinetic scrolling; Xwayland needs axis_discrete to prevent multiple
scroll events when the compositor sends axis deltas greater than 10, etc.

BUG: 404152
FIXED-IN: 5.16.0

Test Plan
  • Content of a webpage in Firefox is moved by one line per each mouse wheel "click";
  • Scrolled gedit using 2 fingers on GNOME Shell, sway, and KDE Plasma; in all three cases wayland debug looked the same (except dialog scroll motions).

Diff Detail

Repository
R108 KWin
Branch
implement-axis-discrete-event
Lint
Lint ErrorsExcuse: cppcheck can't handle q_declare_metatype
SeverityLocationCodeMessage
Errorlibinput/device.h:579CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 8281
Build 8299: arc lint + arc unit
zzag created this revision.Feb 14 2019, 11:06 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 14 2019, 11:06 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 14 2019, 11:06 AM
zzag edited the test plan for this revision. (Show Details)Feb 14 2019, 11:11 AM
zzag edited the test plan for this revision. (Show Details)Feb 14 2019, 11:16 AM