Differential D18989

Remove minor duplicate code and fix related bug
ClosedPublic
Actions

Authored by ognarb on Feb 13 2019, 8:42 PM.

Details

Reviewers
boemann
Group Reviewers
Calligra: 3.0
Commits
R8:791535d78da5: Remove minor duplicate code and fix related bug
Summary

I forgot to change the icon size at one place in the last commit. Fix it and use a small function to avoid duplicate code and a similar bug in the futur.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Feb 13 2019, 8:42 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptFeb 13 2019, 8:42 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
ognarb requested review of this revision.Feb 13 2019, 8:42 PM
boemann accepted this revision.Feb 13 2019, 9:09 PM
This revision is now accepted and ready to land.Feb 13 2019, 9:09 PM
Closed by commit R8:791535d78da5: Remove minor duplicate code and fix related bug (authored by ognarb). · Explain WhyFeb 13 2019, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51627

View Options

libs/widgets/KoModeBox.cpp

Loading...
View Options

libs/widgets/KoModeBox_p.h

Loading...