Differential D18975

[PotD] Port mostly to QQC2
ClosedPublic
Actions

Authored by ngraham on Feb 12 2019, 10:25 PM.

Details

Reviewers
davidedmundson
kossebau
filipf
Group Reviewers
Plasma
Commits
R114:dd5a234771ab: [PotD] Port mostly to QQC2
Summary

Port the Config UI mostly to QQC2, with the exception of the ComboBox,
which still suffers from a visual bug (see the inline comment in the code)

This also has the side effect of working around
https://bugreports.qt.io/browse/QTBUG-70481 and improving the presentation
for people using fractional Qt scale factors.

BUG: 404248
FIXED-IN: 5.15.2

Test Plan

No change at 1x scale. Looks better at 1.2x scale:

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 12 2019, 10:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2019, 10:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 12 2019, 10:25 PM
ngraham edited the summary of this revision. (Show Details)Feb 12 2019, 10:26 PM
ngraham added a comment.Feb 20 2019, 12:20 AM

Friendly ping!

filipf added a subscriber: filipf.Feb 20 2019, 12:30 AM

Looks the same here with 1.2 scaling (verified it was the right file edited).

Before:


After:

Tested the providers and most of them worked.

ngraham edited the summary of this revision. (Show Details)Feb 24 2019, 3:31 PM
filipf accepted this revision.Feb 24 2019, 3:32 PM
This revision is now accepted and ready to land.Feb 24 2019, 3:32 PM
Closed by commit R114:dd5a234771ab: [PotD] Port mostly to QQC2 (authored by ngraham). · Explain WhyFeb 24 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52445

View Options

wallpapers/potd/contents/ui/config.qml

Loading...