Details
Details
- Reviewers
aacid bcooksley - Group Reviewers
Websites: general - Commits
- R910:08e9703c78ad: Add ci metadata to class AppData
Diff Detail
Diff Detail
- Repository
- R910 Capacity Web Framework
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I'd go for ['ci'][1] being optional since i'd say in 99% of the cases $this->data['repository'][1] would be enough, no?
Comment Actions
Good point, might be even 100%. In that case one might not even need an array, but only the group name, and might want to rename the key to "ciGroup" perhaps?
Comment Actions
i'd have it as optional because we never know what may happen with some things like itinerary that likes to be called kde-itinirerary in half of the places and not in the others.
But your call :)