Add ci metadata to class AppData
ClosedPublic

Authored by kossebau on Feb 12 2019, 9:05 PM.

Diff Detail

Repository
R910 Capacity Web Framework
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau requested review of this revision.Feb 12 2019, 9:05 PM
kossebau created this revision.

I'd go for ['ci'][1] being optional since i'd say in 99% of the cases $this->data['repository'][1] would be enough, no?

I'd go for ['ci'][1] being optional since i'd say in 99% of the cases $this->data['repository'][1] would be enough, no?

Good point, might be even 100%. In that case one might not even need an array, but only the group name, and might want to rename the key to "ciGroup" perhaps?

bcooksley accepted this revision.Feb 13 2019, 9:43 AM
bcooksley added a subscriber: bcooksley.

This looks fine to me.

This revision is now accepted and ready to land.Feb 13 2019, 9:43 AM
aacid added a comment.Feb 13 2019, 7:21 PM

i'd have it as optional because we never know what may happen with some things like itinerary that likes to be called kde-itinirerary in half of the places and not in the others.

But your call :)

This revision was automatically updated to reflect the committed changes.