UpdatesPage: Fix icon sizing on small screens

Authored by jbbgameich on Feb 12 2019, 5:30 PM.



On Small screens (e.g phones), not all list items have the same height, for example when a package has a long version string.
Since the width of the icon was previously copied from the height, this resulted in inconsistent icon sizes.

This patch sets the icon size to a constant value, which fixes the problem.

BUG: 404070

Test Plan

Icon sizes are consistent and still correctly sized

Diff Detail

R134 Discover Software Store
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
jbbgameich created this revision.Feb 12 2019, 5:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2019, 5:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jbbgameich requested review of this revision.Feb 12 2019, 5:30 PM

Can you confirm whether or not this also fixes https://bugs.kde.org/show_bug.cgi?id=404070?

Can't test right now, I don't have any updates!

Yes, this looks like the same problem. Since the UpdatesPage width is being decreased when opening the "More information", it's the same effect as on a phone screen where the width is always that small.
Can / should I somehow tag this patch so it marks the bug as resolved?

jbbgameich edited the summary of this revision. (Show Details)Feb 12 2019, 6:19 PM

Thanks, done.

ngraham accepted this revision.Feb 12 2019, 7:18 PM

Got some updates and confirmed that this fixes the bug. Code looks sane. Please land on the Plasma/5.15 branch and then merge to master.

This revision is now accepted and ready to land.Feb 12 2019, 7:18 PM

I'm sorry, I'm not yet used to the Phabricator workflow. My attempt to convert this revision into a proper arc diff I can land failed, since this was initially created by pasting git diff output. If possible, can you land the patch?

Sure, I'll do it this time. The documentation for using arc is really quite good though: https://community.kde.org/Infrastructure/Phabricator

This revision was automatically updated to reflect the committed changes.