Improve KoModeBox display in horizontal Mode
ClosedPublic

Authored by ognarb on Feb 12 2019, 3:49 PM.

Details

Summary

Use less vertical space, don't change anything in vertical Mode

Screenshots:

New:


Old:

Test Plan

Compile, run, no bug found yet :D.

Note: <old>I wasn't able to run calligra with master (crash at startup) so this work isn't tested with master and only the calligra/3.1 branch.</old> Tested with master.

Diff Detail

Repository
R8 Calligra
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8250
Build 8268: arc lint + arc unit
ognarb created this revision.Feb 12 2019, 3:49 PM
Restricted Application added a project: Calligra: 3.0. Β· View Herald TranscriptFeb 12 2019, 3:49 PM
Restricted Application added a subscriber: Calligra-Devel-list. Β· View Herald Transcript
ognarb requested review of this revision.Feb 12 2019, 3:49 PM
ognarb edited the summary of this revision. (Show Details)Feb 12 2019, 3:50 PM
ognarb added reviewers: Calligra: 3.0, VDG.
ognarb updated this revision to Diff 51523.Feb 12 2019, 3:51 PM

Remove debug output

ngraham accepted this revision as: VDG.Feb 12 2019, 3:53 PM
ngraham added a subscriber: ngraham.

Certainly a visual improvement! +1!

Wait for code review before landing, of course.

abetts added a subscriber: abetts.Feb 12 2019, 3:53 PM

It is pretty rough. It works, but needs better looks. The toolbar section now takes up almost half of the screen.

The first image is the new version, not the old version. :)

The first image is the new version, not the old version. :)

Oh good! I was confused.

Thank you

boemann accepted this revision.Feb 12 2019, 3:57 PM
boemann added a subscriber: boemann.

I like it

This revision is now accepted and ready to land.Feb 12 2019, 3:57 PM

Ok thanks for the review, I will retry to compile calligra master and see if it's still work and then land this diff. πŸ˜„

Please remove trailing whitespace.

ognarb updated this revision to Diff 51589.Feb 13 2019, 2:03 PM

remove trailing whitespace

ognarb updated this revision to Diff 51594.Feb 13 2019, 3:10 PM

remove more trailing whitespace

This revision was automatically updated to reflect the committed changes.
ognarb edited the test plan for this revision. (Show Details)Feb 13 2019, 3:15 PM