[wayland] Handle sizes in ShellClient::transientPlacement
AcceptedPublic

Authored by davidedmundson on Tue, Feb 12, 12:21 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Summary

placeIn did not handle the case for a popup not having had the size
already set and only being available via
m_xdgShellPopup->initialSize(). This is needed if we want to call placeIn
at the correct time, before the window is mapped.

There was also a logic bug when sliding popups. We called the
confusingly named setX thinking it would be move the popup keeping the
width the same. In practice it moves the left edge keeping the right
position the same. This wasn't an issue as the size was
discarded.

Handling the resize constraint is not yet done, but it should now be
even more trivial.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8245
Build 8263: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptTue, Feb 12, 12:21 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Tue, Feb 12, 12:21 PM
davidedmundson retitled this revision from Handle sizes in ShellClient::transientPlacement to [wayland] Handle sizes in ShellClient::transientPlacement.Tue, Feb 12, 12:23 PM
zzag added a subscriber: zzag.Tue, Feb 12, 1:40 PM
zzag added inline comments.
placement.cpp
503–505

popupGeometry would be a better name. Also, we probably don't need this variable at all.

davidedmundson marked an inline comment as done.Wed, Feb 13, 12:28 PM
zzag added a comment.Wed, Feb 13, 1:26 PM

Is it WIP? (I'm asking because Reviewers field is not set)

remove an irrelevant change

Ready for a review I think.

zzag accepted this revision.Wed, Feb 13, 1:48 PM
This revision is now accepted and ready to land.Wed, Feb 13, 1:48 PM