Add missing XdgShellPopup::ackConfigure
ClosedPublic

Authored by davidedmundson on Tue, Feb 12, 12:07 PM.

Details

Summary

When XdgShellV6 was retrofitted to match the XdgShellV5 API, this got
missed in the client.

It went unnoticed as Kwin didn't handle configure events at the time.

Test Plan

Used in kwin unit tests

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Feb 12, 12:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Tue, Feb 12, 12:07 PM
zzag accepted this revision.Tue, Feb 12, 1:41 PM
zzag added a subscriber: zzag.
zzag added inline comments.
src/client/xdgshell.cpp
367

Please remove one extra new line.

This revision is now accepted and ready to land.Tue, Feb 12, 1:41 PM
zzag added inline comments.Tue, Feb 12, 1:42 PM
src/client/xdgshell.h
594

Also, maybe @since?

src/client/xdgshell_v6.cpp
588

here as well

davidedmundson marked 3 inline comments as done.Tue, Feb 12, 1:46 PM
This revision was automatically updated to reflect the committed changes.