Differential D18954

Add missing XdgShellPopup::ackConfigure
ClosedPublic
Actions

Authored by davidedmundson on Feb 12 2019, 12:07 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R127:254d15fa912f: Add missing XdgShellPopup::ackConfigure
R127:9c95e203eae7: Add missing XdgShellPopup::ackConfigure
Summary

When XdgShellV6 was retrofitted to match the XdgShellV5 API, this got
missed in the client.

It went unnoticed as Kwin didn't handle configure events at the time.

Test Plan

Used in kwin unit tests

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 12 2019, 12:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 12 2019, 12:07 PM
zzag accepted this revision.Feb 12 2019, 1:41 PM
zzag added a subscriber: zzag.
zzag added inline comments.
src/client/xdgshell.cpp
367

Please remove one extra new line.

This revision is now accepted and ready to land.Feb 12 2019, 1:41 PM
zzag added inline comments.Feb 12 2019, 1:42 PM
src/client/xdgshell.h
594

Also, maybe @since?

src/client/xdgshell_v6.cpp
588

here as well

davidedmundson marked 3 inline comments as done.Feb 12 2019, 1:46 PM
Closed by commit R127:9c95e203eae7: Add missing XdgShellPopup::ackConfigure (authored by davidedmundson). · Explain WhyFeb 12 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51500

View Options

src/client/xdgshell.h

Loading...
View Options

src/client/xdgshell.cpp

Loading...
View Options

src/client/xdgshell_p.h

Loading...
View Options

src/client/xdgshell_stable.cpp

Loading...
View Options

src/client/xdgshell_v6.cpp

Loading...