CubeScript: fixes line continuation escape in strings
ClosedPublic

Authored by nibags on Feb 12 2019, 11:23 AM.

Details

Summary

Fix the line continuation escape in strings.

CubeScript files use the extension .cfg, which is used by default by Nagios, making it impossible to add a test file. It might be a good idea to add the extension *.cubescript and use it for the test file.

Diff Detail

Repository
R216 Syntax Highlighting
Branch
fix-escape-cubescript
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8226
Build 8244: arc lint + arc unit
nibags created this revision.Feb 12 2019, 11:23 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 12 2019, 11:23 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Feb 12 2019, 11:23 AM
cullmann requested changes to this revision.Feb 12 2019, 7:24 PM

You can add a unit test, you just need to add a small .syntax file in addition to the test, e.g. see

https://cgit.kde.org/syntax-highlighting.git/tree/autotests/input/adblock.txt.syntax

If you add a test, this can go in.

This revision now requires changes to proceed.Feb 12 2019, 7:24 PM
nibags updated this revision to Diff 51553.Feb 12 2019, 9:18 PM
  • Add unit test
cullmann accepted this revision.Feb 12 2019, 9:43 PM
This revision is now accepted and ready to land.Feb 12 2019, 9:43 PM
nibags closed this revision.Feb 12 2019, 9:47 PM