When opening a new using the context menu the new tab should be placed
after the currently open tab, not at the end of the tab list.
BUG: 403690
ngraham | |
elvisangelaccio |
Dolphin |
When opening a new using the context menu the new tab should be placed
after the currently open tab, not at the end of the tab list.
BUG: 403690
Open multiple tabs and select a different tab than the last one.
Open a new tab using the context menu and see that it opens after the currently
selected tab.
Open a tab using Ctrl+T and see that it opens at the end.
No Linters Available |
No Unit Test Coverage |
Buildable 8408 | |
Build 8426: arc lint + arc unit |
src/dolphintabwidget.h | ||
---|---|---|
124–125 | In general, using bools as arguments is not ideal since it's not very readable. Consider defining an Enum instead. For further information see for example: |
It's great! Very usable--a bit improvement, in my eyes. This is the behavior that web browsers use too and I think it's very humane.
@elvisangelaccio, are you good with this?
src/dolphintabwidget.cpp | ||
---|---|---|
161–168 | How about a simpler if? int newTabIndex = -1; if (tabPlacement == AfterCurrent) { newTabIndex = currentIndex() + 1; } (we can always make it a switch if we add new values to the enum, which is unlikely). | |
src/dolphintabwidget.h | ||
42 | How about AfterCurrentTab and AfterLastTab ? The underscore is unusual in camelcase names. |
Change TabPlacement enum names.
Simplify the code that calculates the index of the new tab.
Please use FEATURE: instead of BUG: in the commit message.
Do you have commit access?
Sorry, I didn't see your comment to after I had landed the change :) Hope it is ok anyway.