This is a big UI change, I'm not sure if it shouldn't be optional in
some way. Some apps have set tooltips on their actions in lieu of
this, and they will get two shortcuts displays this way.
Details
Details
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8175 Build 8193: arc lint + arc unit
Comment Actions
Feels a bit in-your-face to me, it can make sense for this application bug for e.g. Discover it would be a bit overwhelming.
I'd prefer keeping it in the tooltip for something generic.
| src/controls/private/ContextDrawerActionItem.qml | ||
|---|---|---|
| 75 | this doesn't anchor to the text, won't the text be going over the shortcut if it's too long? | |
Comment Actions
This makes sense when the drawer is being used as a sort of slide-in context menu. But in Discover for example, we make drawer be always visible (on desktop at least) and abuse it to hold navigation elements.
Optional but on-by-default-for-actions would make sense to me if we can optimize the presentation.
| src/controls/private/ContextDrawerActionItem.qml | ||
|---|---|---|
| 75 | It's a layout (you don't anchor in them) ... did you see the screenshot and description? | |
| src/controls/private/GlobalDrawerActionItem.qml | ||
|---|---|---|
| 102 | adding also && root.modal should fix the discover and other always-showing-sidebar apps use case. Pretty sure the label will break on collapsed mode. should probably be visible: modelData.__shortcut.enabled && !Settings.tabletMode && root.modal && !root.collapsible | |