Allow compositors to send discrete axis values
Needs ReviewPublic

Authored by zzag on Feb 11 2019, 7:35 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

So far not all v5 features were implemented because most of them are
optional. But given that XWayland needs axis_discrete event maybe it's
time to implement them.

CCBUG: 404152

Diff Detail

Repository
R127 KWayland
Branch
pointer-axis-value-discrete
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8280
Build 8298: arc lint + arc unit
zzag created this revision.Feb 11 2019, 7:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 11 2019, 7:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Feb 11 2019, 7:35 PM
zzag retitled this revision from Implement optional events from wl_pointer v5 to Send optional events from wl_pointer v5.Feb 11 2019, 7:43 PM
zzag edited the summary of this revision. (Show Details)Feb 11 2019, 8:02 PM
mthw added a subscriber: mthw.Feb 12 2019, 6:52 AM
zzag updated this revision to Diff 51659.Feb 14 2019, 11:00 AM

Add Unknown axis source.

@davidedmundson Would it make sense to have something like

void pointerAxisV5(Qt::Orientations orientations, const QPointF &delta,
                   const QPoint &discreteDelta, PointerAxisSource source);

so we could send a diagonal scroll motion in one frame?

so we could send a diagonal scroll motion in one frame?

We have this for a few things, such as clicking and moving.

IMHO we should make frame() explicitly sent from the caller.
I've hit this a few times (mostly wl_output) where KWayland tries to make things "easy" but in practice ends up making it harder to follow the protocol accurately.

Hard to add retroactively in KF5 though :/

zzag added a comment.Feb 14 2019, 11:22 AM

IMHO we should make frame() explicitly sent from the caller.

Yeah, I'd prefer this way as well to be honest...

Hard to add retroactively in KF5 though :/

So, it would be KF6 stuff, right?

zzag retitled this revision from Send optional events from wl_pointer v5 to Allow compositors to send discrete axis deltas.Tue, Apr 9, 12:07 PM
zzag retitled this revision from Allow compositors to send discrete axis deltas to Allow compositors to send discrete axis values.