Differential D18931

Make the new Window Decoration KCM translatable (patch by Victor Ryzhykh)
ClosedPublic
Actions

Authored by yurchor on Feb 11 2019, 5:17 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Localization
Commits
R108:0cf7cca2ab6a: Make the new Window Decoration KCM translatable
Summary

The current KCM is not completely translatable due to the catalog misnaming.

The current untranslatable KCM (Russian locale):

Test Plan

Rename the catalog, recompile. The translations should be visible again.

Diff Detail

Repository
R108 KWin
Branch
kcmdec_trans (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8163
Build 8181: arc lint + arc unit
yurchor created this revision.Feb 11 2019, 5:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 11 2019, 5:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
yurchor requested review of this revision.Feb 11 2019, 5:17 PM
yurchor edited the summary of this revision. (Show Details)Feb 11 2019, 5:19 PM
ltoscano added a subscriber: ltoscano.Feb 11 2019, 5:25 PM

I guess it makes sense. I guess it should go also to Plasma/5.15.
If anyone else disagrees, I will approve it tomorrow.
When you commit the patch, please remember to use the git --author=<> --amend to change the author of the patch.

davidedmundson accepted this revision.Feb 11 2019, 5:41 PM
davidedmundson added a subscriber: davidedmundson.

The KCM only changed in master.

5.15 should be fine.

This revision is now accepted and ready to land.Feb 11 2019, 5:41 PM
Closed by commit R108:0cf7cca2ab6a: Make the new Window Decoration KCM translatable (authored by victorr, committed by yurchor). · Explain WhyFeb 11 2019, 6:13 PM
This revision was automatically updated to reflect the committed changes.
ltoscano added a comment.Feb 12 2019, 8:49 AM

Ok, so it was changed in the stable branch in the end. I guess that it should not matter.

Revision Contents
Changeset List

Diff 51425

View Options

kcmkwin/kwindecoration/CMakeLists.txt

Loading...
View Options

kcmkwin/kwindecoration/Messages.sh

Loading...