Differential D18925

[Icon Applet] Parse jump list actions and open with actions on demand
ClosedPublic
Actions

Authored by broulik on Feb 11 2019, 2:35 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:b884003bebd7: [Icon Applet] Parse jump list actions and open with actions on demand
Summary

Doing this on startup can easily add up to 20ms startup time for every icon pointing to a file.
It is not an issue with application links that don't have open with actions fortunately.

Test Plan
  • Open with still works, both the main entry as well as the sub entries
  • Open containing folder still works
  • Jump list actions still works
  • Still properly updates when you change the Link URL at runtime in icon applet settings

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 11 2019, 2:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 11 2019, 2:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 11 2019, 2:35 PM
broulik edited the summary of this revision. (Show Details)
hein accepted this revision.Feb 11 2019, 5:57 PM
This revision is now accepted and ready to land.Feb 11 2019, 5:57 PM
Closed by commit R120:b884003bebd7: [Icon Applet] Parse jump list actions and open with actions on demand (authored by broulik). · Explain WhyFeb 11 2019, 7:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/icon/iconapplet.cpp (108 lines)

Diff 51439

View Options

applets/icon/iconapplet.cpp

Loading...