- Group Reviewers
- R474:9b0c673642bf: Move the camera selection into the configuration view
+1 on turning this into a combobox so you can see the text labels. I'm not sure the left drawer is the right place for it though; that puts it right below the "Effects Gallery" header text, which makes that header inaccurate, since this has nothing to do with effects.
It should probably go in the other drawer on the "Configure Kamoso" page.
Actually, just a few few more requested changes...
|4 ↗||(On Diff #51505)|
Actually, is this still needed?
Also probably needs visible: devicesModel.count>1, or else when there's only a single camera the header will be visible with no combobox underneath it.
Oh right, because the combobox has its enabled: property changed conditionally, not visible:. We should hide it entirely instead of just disabling it when there's just one camera. The HIG says that it's appropriate to do this for cases where hardware isn't available, of which this is an example.