Differential D18912

[libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads
ClosedPublic
Actions

Authored by atulbi on Feb 10 2019, 10:09 PM.

Details

Reviewers
ngraham
romangg
davidedmundson
Group Reviewers
Plasma
Commits
R119:8ca7335288fa: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for…
Summary
  • Added Properties to wayland Backend
  • User can switch between areas and clickfinger methods if touchpads has no physical buttons.
  • when areas mode is selected, user can enable and enable/disable middle-emulation.
  • In clickfinger mode , for informative purposes checked but disabled checkbox will be shown with "Press anywhere with three fingers" text.

FEATURE: 387156
FIXED-IN: 5.16.0

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atulbi created this revision.Feb 10 2019, 10:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 10 2019, 10:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
atulbi requested review of this revision.Feb 10 2019, 10:09 PM
atulbi edited the summary of this revision. (Show Details)Feb 10 2019, 10:11 PM
atulbi added a reviewer: ngraham.
ngraham edited the summary of this revision. (Show Details)Feb 10 2019, 10:45 PM
davidedmundson accepted this revision.Mar 5 2019, 2:35 PM
davidedmundson added inline comments.
kcms/touchpad/src/kcm/libinput/main.qml
602

You could resolve all of this by using onToggled instead of onChecked

but I understand you're just following the existing pattern

This revision is now accepted and ready to land.Mar 5 2019, 2:35 PM
ngraham accepted this revision.Mar 5 2019, 4:05 PM

UI looks good to me too.

Closed by commit R119:8ca7335288fa: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for… (authored by atulbi, committed by ngraham). · Explain WhyMar 5 2019, 7:40 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Mar 5 2019, 7:43 PM

Nice work. Any chance you'd be interested in porting the Wayland-only libinput touchpad KCM to work on X11 too, just like how the Libinput mouse KCM does?

https://bugs.kde.org/show_bug.cgi?id=387153

atulbi added a comment.Mar 5 2019, 10:27 PM

Thanks. Yes, I'll take this for sure.

ngraham added a comment.Mar 5 2019, 11:00 PM

Wonderful news!!!

Revision Contents
Changeset List

Diff 53230

View Options

kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h

Loading...
View Options

kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp

Loading...
View Options

kcms/touchpad/src/kcm/libinput/main.qml

Loading...