Use Kformat for bit and sample rate
ClosedPublic

Authored by astippich on Sun, Feb 10, 8:05 PM.

Details

Summary

Format bit and sample rate to 3 significant digits

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Sun, Feb 10, 8:05 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSun, Feb 10, 8:05 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Sun, Feb 10, 8:05 PM

Any chance you can attach a screenshot of what this looks like now in Dolphin's information panel?

I actually have not started porting Dolphin to the new feature yet, since this will require Kf 5.56 and is probably stuff for 19.08. If a screenshot is a must I will adjust priorities :)

No, I just want to get a sense of what the user-facing changes will be. :)

The unit will be corrected (it is _bit_rate) and three significant digits will always be shown:
123 400 will be displayed as 123 kbit/s
1 234 000 will be displayed as 1.23 Mbit/s
12 345 000 will be displayed as 12.3 Mbit/s

ngraham accepted this revision.Sun, Feb 10, 9:27 PM

Ah yes.

This revision is now accepted and ready to land.Sun, Feb 10, 9:27 PM
This revision was automatically updated to reflect the committed changes.