[SwipeListItem] Use a real toolbutton to improve usability

Authored by ngraham on Feb 10 2019, 7:22 PM.



Use a real toolbutton instead of a custom icon + mouse area, which
provides hovered and clicked states automatically and simplifies
the code a bit.

BUG: 403641
FIXED-IN: 5.56

Test Plan

Hovered state:

Pressed state:

Diff Detail

R169 Kirigami
use-real-toolbuttons (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 8129
Build 8147: arc lint + arc unit
ngraham created this revision.Feb 10 2019, 7:22 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 10 2019, 7:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 10 2019, 7:22 PM
apol added a subscriber: apol.Feb 10 2019, 8:19 PM

Overall +1


This undefined will just warn on tablet mode. I'd remove it, do we need to specify it? A ToolButton should already behave properly.


Should move these values to Units, can be done in a separate patch.

ngraham updated this revision to Diff 51357.Feb 10 2019, 9:25 PM
ngraham marked an inline comment as done.

Remove unnecessary hoverEnabled property

ngraham added inline comments.Feb 10 2019, 9:25 PM

Sure, will do that after this lands.

mart accepted this revision.Feb 11 2019, 3:15 PM
This revision is now accepted and ready to land.Feb 11 2019, 3:15 PM
This revision was automatically updated to reflect the committed changes.