Differential D18891

Avoid leaking a QObject in ExternalExtractor
ClosedPublic
Actions

Authored by bruns on Feb 10 2019, 12:36 AM.

Details

Reviewers
ngraham
poboiko
astippich
Group Reviewers
Baloo
Frameworks
Commits
R286:73d5fbbf5fb0: Avoid leaking a QObject in ExternalExtractor
Summary

Passing a nullptr as a parent is fine, passing an untracked object
definitely is not.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 10 2019, 12:36 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 10 2019, 12:36 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Feb 10 2019, 12:36 AM
dhaumann added a subscriber: dhaumann.EditedFeb 10 2019, 8:30 AM

That looks reasonable, if ExtractorPlugin even has QObject * parent = nullptr I'd even remove nullptr as well.

bruns added a comment.Feb 10 2019, 2:29 PM
In D18891#409003, @dhaumann wrote:

That looks reasonable, if ExtractorPlugin even has QObject * parent = nullptr I'd even remove nullptr as well.

No, no default value ...

ngraham accepted this revision.Feb 10 2019, 2:47 PM
This revision is now accepted and ready to land.Feb 10 2019, 2:47 PM
Closed by commit R286:73d5fbbf5fb0: Avoid leaking a QObject in ExternalExtractor (authored by bruns). · Explain WhyFeb 10 2019, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/externalextractor.cpp (2 lines)

Diff 51316

View Options

src/externalextractor.cpp

Loading...