Passing a nullptr as a parent is fine, passing an untracked object
definitely is not.
Details
Details
- Reviewers
ngraham poboiko astippich - Group Reviewers
Baloo Frameworks - Commits
- R286:73d5fbbf5fb0: Avoid leaking a QObject in ExternalExtractor
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
That looks reasonable, if ExtractorPlugin even has QObject * parent = nullptr I'd even remove nullptr as well.