Currently, images from cover.jpg files in the currently playing file are unconditionally overwritten with embedded covers, so cover images are never displayed for files that don't have embedded cover info.
Details
Details
- Reviewers
mpyne - Commits
- R344:849e8dca4021: Fix displaying covers from cover.jpg files
Played some files without embedded covers, the cover image from cover.jpg is correctly displayed
Diff Detail
Diff Detail
- Repository
- R344 Juk
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This is good to commit. Note that JuK's repository is in testing for a trial KDE is running of GitLab, so you'll need to commit to the JuK repository at https://invent.kde.org/kde/juk
You can also enter other pull requests or issues for JuK there while we demo GitLab's features.