Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)
ClosedPublic

Authored by bruns on Feb 9 2019, 3:01 PM.

Details

Summary

There is no need to delete and create a new Private on assignment, it is
sufficient to reassign its members.

File::load(url) resets the url, afterwards he old corresponding property
map is no longer valid, clear it.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8072
Build 8090: arc lint + arc unit
bruns created this revision.Feb 9 2019, 3:01 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 9 2019, 3:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Feb 9 2019, 3:01 PM
ngraham accepted this revision.Feb 10 2019, 6:40 PM

Yep, makes sense.

This revision is now accepted and ready to land.Feb 10 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.