Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)
ClosedPublic

Authored by bruns on Sat, Feb 9, 3:01 PM.

Details

Summary

There is no need to delete and create a new Private on assignment, it is
sufficient to reassign its members.

File::load(url) resets the url, afterwards he old corresponding property
map is no longer valid, clear it.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sat, Feb 9, 3:01 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSat, Feb 9, 3:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Sat, Feb 9, 3:01 PM
ngraham accepted this revision.Sun, Feb 10, 6:40 PM

Yep, makes sense.

This revision is now accepted and ready to land.Sun, Feb 10, 6:40 PM
This revision was automatically updated to reflect the committed changes.