Differential D18876

Replace some math macro definitions
ClosedPublic
Actions

Authored by andreagenor on Feb 9 2019, 2:09 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

R374:d69b9ee1426d: Replace some math macro definitions

Summary

Remove some unused include of math and add a std:: scope to math functions

Diff Detail

Repository

R374 KolourPaint

Branch

fix/math-macro

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8068
Build 8086: arc lint + arc unit

andreagenor requested review of this revision.Feb 9 2019, 2:09 PM

andreagenor created this revision.

Harbormaster completed remote builds in B8068: Diff 51254.Feb 9 2019, 2:09 PM

andreagenor added a reviewer: tcanabrava.Feb 9 2019, 2:09 PM

seems pretty straigthforward.

This revision is now accepted and ready to land.Feb 10 2019, 9:05 PM

Closed by commit R374:d69b9ee1426d: Replace some math macro definitions (authored by andreagenor, committed by tcanabrava). · Explain WhyFeb 14 2019, 9:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			commands/imagelib/transforms/kpTransformResizeScaleCommand.cpp (1 line)
M			dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp (1 line)
M			document/kpDocument.cpp (1 line)
M			document/kpDocument_Open.cpp (1 line)
M			document/kpDocument_Save.cpp (1 line)
M			document/kpDocument_Selection.cpp (1 line)
M			imagelib/effects/kpEffectBalance.cpp (2 lines)
M			imagelib/effects/kpEffectHSV.cpp (2 lines)
M			imagelib/kpDocumentMetaInfo.cpp (2 lines)
M			kpDefs.h (7 lines)
M			pixmapfx/kpPixmapFX_DrawShapes.cpp (1 line)
M			pixmapfx/kpPixmapFX_GetSetPixmapParts.cpp (1 line)
M			pixmapfx/kpPixmapFX_Transforms.cpp (26 lines)
M			tools/polygonal/kpToolPolygonalBase.cpp (18 lines)
M			views/kpView.cpp (1 line)
M			widgets/colorSimilarity/kpColorSimilarityCubeRenderer.cpp (12 lines)
M			widgets/colorSimilarity/kpColorSimilarityHolder.cpp (2 lines)
M			widgets/imagelib/effects/kpEffectBalanceWidget.cpp (2 lines)
M			widgets/imagelib/effects/kpNumInput.cpp (2 lines)

Diff 51254

commands/imagelib/transforms/kpTransformResizeScaleCommand.cpp

Loading...

dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp

Loading...

document/kpDocument.cpp

Loading...

document/kpDocument_Open.cpp

Loading...

document/kpDocument_Save.cpp

Loading...

document/kpDocument_Selection.cpp

Loading...

imagelib/effects/kpEffectBalance.cpp

Loading...

imagelib/effects/kpEffectHSV.cpp

Loading...

imagelib/kpDocumentMetaInfo.cpp

Loading...

kpDefs.h

Loading...

pixmapfx/kpPixmapFX_DrawShapes.cpp

Loading...

pixmapfx/kpPixmapFX_GetSetPixmapParts.cpp

Loading...

pixmapfx/kpPixmapFX_Transforms.cpp

Loading...

tools/polygonal/kpToolPolygonalBase.cpp

Loading...

views/kpView.cpp

Loading...

widgets/colorSimilarity/kpColorSimilarityCubeRenderer.cpp

Loading...

widgets/colorSimilarity/kpColorSimilarityHolder.cpp

Loading...

widgets/imagelib/effects/kpEffectBalanceWidget.cpp

Loading...

widgets/imagelib/effects/kpNumInput.cpp

Loading...