Move selection code from TerminalDisplay to ScreenWindow
Needs ReviewPublic
Actions

Authored by sandsmark on Feb 9 2019, 12:46 PM.

Details

Reviewers

hindenburg
ngraham
pavelkh

Group Reviewers

Konsole

Summary

Trying to separate out stuff that isn't "purely" rendering/UI
code out of TerminalDisplay, to slim down the class a bit
so it is more manageable.

Diff Detail

Repository

R319 Konsole

Lint

Lint Skipped

Unit

Unit Tests Skipped

sandsmark created this revision.Feb 9 2019, 12:46 PM

Restricted Application added a project: Konsole. · View Herald TranscriptFeb 9 2019, 12:46 PM

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

sandsmark requested review of this revision.Feb 9 2019, 12:46 PM

sandsmark added a dependency: D18870: Clean up/refactor selection code in TerminalDisplay.

updated so it applies cleanly

hindenburg edited the summary of this revision. (Show Details)Mar 5 2019, 3:07 PM

Thanks still looking at this - need to find a better diff program to follow something this complex

The biggest part I have trouble following are the new changes to the findWordStart and findWordEnd. I wonder if doing a straight move to ScreenWindow and then changing the code in a new patch would be best.

Revision Contents
Changeset List

			Path	Packages
M			src/ScreenWindow.h (60 lines)
M			src/ScreenWindow.cpp (451 lines)
M			src/TerminalDisplay.h (19 lines)
M			src/TerminalDisplay.cpp (483 lines)

	Status	Author	Revision
	Needs Review	sandsmark	D18871 Move selection code from TerminalDisplay to ScreenWindow
	Needs Review	sandsmark	D18870 Clean up/refactor selection code in TerminalDisplay