Clean up/refactor selection code in TerminalDisplay
Needs ReviewPublic

Authored by sandsmark on Feb 9 2019, 12:43 PM.



Clarified the variable and member names, straightened out the code flow, fixes the (crashing) issue with the selections properly.

Also have a separate patch on top of this to move most of the code out of TerminalDisplay (my goal is to get TerminalDisplay.cpp below 3000 lines :-).

Test Plan

Same as the ones from the earlier commits related to this, but no autotests yet (want to wait until the code is in the right place first).

Diff Detail

R319 Konsole
Lint Skipped
Unit Tests Skipped
sandsmark created this revision.Feb 9 2019, 12:43 PM
Restricted Application added a project: Konsole. · View Herald TranscriptFeb 9 2019, 12:43 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
sandsmark requested review of this revision.Feb 9 2019, 12:43 PM

This doesn't apply now - I believe the fix the extended bug was already committed w/ your other patch.

sandsmark updated this revision to Diff 53022.Mar 2 2019, 7:58 PM

Updated so it applies cleanly.