Switch from reading Cargo.toml to using a cli flag
Needs ReviewPublic
Actions

Authored by bgoldberg on Feb 9 2019, 7:26 AM.

Details

Reviewers

Summary

Trying the read Cargo.toml is unnecessary is causing bug 404127 so I removed that feature and replaced it with a cli flag that allows the user to give the rust edition.

Diff Detail

Repository

R881 Rust Qt Binding Generator

Lint

Lint Skipped

Unit

Unit Tests Skipped

bgoldberg requested review of this revision.Feb 9 2019, 7:26 AM

bgoldberg created this revision.

bgoldberg added a reviewer: vandenoever.

I think bug 404127 is fixed in 0.3.1. The bindings file states where the rust directory is. That directory contains Cargo.toml.

I appreciate the patch, but I'm not convinced that it is needed.

Revision Contents
Changeset List

			Path	Packages
M			Cargo.toml (1 line)
M			src/bin/rust_qt_binding_generator.rs (9 lines)
M			src/configuration.rs (18 lines)
M			src/lib.rs (3 lines)

Diff 51237

View Options

Cargo.toml

View Options

src/bin/rust_qt_binding_generator.rs

View Options

src/configuration.rs

View Options

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51237			Feb 9 2019, 7:24 AM	★	★

Switch from reading Cargo.toml to using a cli flagNeeds ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 51237

Cargo.toml

src/bin/rust_qt_binding_generator.rs

src/configuration.rs

src/lib.rs

Switch from reading Cargo.toml to using a cli flag
Needs ReviewPublic
Actions

Revision Contents
Changeset List