check_function_exists has some shortcomings, which fails to detect
isnan when build against musl libc. The cmake documentation [1]
suggests to prefer check_symbol_exists, which detects isnan/isinf
fine on both glibc and musl.
[1] https://cmake.org/cmake/help/latest/module/CheckFunctionExists.html#command:check_function_exists
Builds with glibc and musl
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
What about the other check_function_exists, should they also be changed?
Also, do you know when check_symbol_exists was introduced?
We still use cmake 2.8.12.
Changed them, too.
Also, do you know when check_symbol_exists was introduced?
We still use cmake 2.8.12.
No, but it's not that "new" and 2.8.12 definitely has it: https://cmake.org/cmake/help/v2.8.12/cmake.html#module:CheckSymbolExists
| filters/words/msword-odf/wv2/CMakeLists.txt | ||
|---|---|---|
| 82 | missing "h" in "zlib.h" | |