Support for FlatBuffers schema, for grammar see
https://google.github.io/flatbuffers/flatbuffers_grammar.html
Details
- Reviewers
dhaumann cullmann - Commits
- R216:926feb55fa02: FlatBuffers schema syntax highlighting
Opened some Flatbuffers in kate and Qt Creator
Diff Detail
- Repository
- R216 Syntax Highlighting
- Branch
- flatbuffers (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8113 Build 8131: arc lint + arc unit
Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.
data/syntax/flatbuffers.xml | ||
---|---|---|
4 ↗ | (On Diff #51217) | Could you add license="MIT"? |
58 ↗ | (On Diff #51217) | Does the Int rule do the same? https://docs.kde.org/stable5/en/applications/katepart/highlight.html ...or does it not include the minus sign? |
Hi Dominik, thanks so much for the review :) I took the default flatbuffers file from their docs as that has most of the keywords/attributes. Their documentation is Apache licensed, so I guess this should be OK?
I think that is ok ;=)
Thanks for the contribution, and nice to read from you Harald, too ;=)