FlatBuffers schema syntax highlighting
ClosedPublic
Actions

Authored by harald on Feb 8 2019, 8:09 PM.

Details

Reviewers

dhaumann
cullmann

Commits

R216:926feb55fa02: FlatBuffers schema syntax highlighting

Summary

Support for FlatBuffers schema, for grammar see
https://google.github.io/flatbuffers/flatbuffers_grammar.html

Test Plan

Opened some Flatbuffers in kate and Qt Creator

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

harald created this revision.Feb 8 2019, 8:09 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 8 2019, 8:09 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

harald requested review of this revision.Feb 8 2019, 8:09 PM

Harbormaster completed remote builds in B8049: Diff 51217.Feb 8 2019, 8:09 PM

Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.

data/syntax/flatbuffers.xml
5	Could you add license="MIT"?
59	Does the Int rule do the same? https://docs.kde.org/stable5/en/applications/katepart/highlight.html ...or does it not include the minus sign?

This revision is now accepted and ready to land.Feb 8 2019, 10:31 PM

Added test, license and highlighting of attributes

Harbormaster completed remote builds in B8113: Diff 51331.Feb 10 2019, 5:39 PM

In D18864#408305, @dhaumann wrote:

Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.

Hi Dominik, thanks so much for the review :) I took the default flatbuffers file from their docs as that has most of the keywords/attributes. Their documentation is Apache licensed, so I guess this should be OK?

I think that is ok ;=)
Thanks for the contribution, and nice to read from you Harald, too ;=)

dhaumann accepted this revision.Feb 11 2019, 6:16 AM

Closed by commit R216:926feb55fa02: FlatBuffers schema syntax highlighting (authored by harald). · Explain WhyFeb 11 2019, 9:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	autotests/folding/test.fbs.fold (33 lines)
A	M	autotests/html/test.fbs.html (40 lines)
A	M	autotests/input/test.fbs (33 lines)
A	M	autotests/reference/test.fbs.ref (33 lines)
A	M	data/syntax/flatbuffers.xml (114 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51217	9a63d86		Feb 8 2019, 8:09 PM	★	★
Diff 2	51331	9a63d86	Added test, license and highlighting of attributes	Feb 10 2019, 5:39 PM	★	★
Diff 3	51398	dedc3f9	R216:926feb55fa0224ead7acceabf549221ccb264993	Feb 11 2019, 9:48 AM	★	★