FlatBuffers schema syntax highlighting
ClosedPublic

Authored by harald on Fri, Feb 8, 8:09 PM.

Details

Summary

Support for FlatBuffers schema, for grammar see
https://google.github.io/flatbuffers/flatbuffers_grammar.html

Test Plan

Opened some Flatbuffers in kate and Qt Creator

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
harald created this revision.Fri, Feb 8, 8:09 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFri, Feb 8, 8:09 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
harald requested review of this revision.Fri, Feb 8, 8:09 PM
dhaumann accepted this revision.Fri, Feb 8, 10:31 PM
dhaumann added a subscriber: dhaumann.

Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.

data/syntax/flatbuffers.xml
5

Could you add license="MIT"?

59

Does the Int rule do the same?

https://docs.kde.org/stable5/en/applications/katepart/highlight.html

...or does it not include the minus sign?

This revision is now accepted and ready to land.Fri, Feb 8, 10:31 PM
harald updated this revision to Diff 51331.Sun, Feb 10, 5:39 PM

Added test, license and highlighting of attributes

harald marked 2 inline comments as done.Sun, Feb 10, 5:42 PM

Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.

Hi Dominik, thanks so much for the review :) I took the default flatbuffers file from their docs as that has most of the keywords/attributes. Their documentation is Apache licensed, so I guess this should be OK?

cullmann accepted this revision.Mon, Feb 11, 6:01 AM
cullmann added a subscriber: cullmann.

I think that is ok ;=)
Thanks for the contribution, and nice to read from you Harald, too ;=)

dhaumann accepted this revision.Mon, Feb 11, 6:16 AM
This revision was automatically updated to reflect the committed changes.