Fix crash when extending selection
ClosedPublic

Authored by sandsmark on Fri, Feb 8, 7:47 PM.

Details

Summary

When doing word selection use the previous selection anchor if the new one is out of bounds (user scrolled out of view or similar).

A more proper (but still not really proper) fix than b85bbaa8c8807ab3619cddc35b634c2bb43e09fb reverted by 213afc0e0ceebc88c90552cd91fa8680e54603ed

I have a branch refactoring the word selection stuff a bit, but it's a bit more invasive. This is the minimal change I could get to fix it.

Test Plan

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark created this revision.Fri, Feb 8, 7:47 PM
Restricted Application added a project: Konsole. · View Herald TranscriptFri, Feb 8, 7:47 PM
Restricted Application edited subscribers, added: konsole-devel; removed: Konsole. · View Herald Transcript
sandsmark requested review of this revision.Fri, Feb 8, 7:47 PM
hindenburg accepted this revision.Mon, Feb 11, 10:15 PM

Ok good thanks I can't get it to crash and don't see any regressions

This revision is now accepted and ready to land.Mon, Feb 11, 10:15 PM
This revision was automatically updated to reflect the committed changes.