Improve the look of the Fonts KCM UI
ClosedPublic

Authored by GB_2 on Fri, Feb 8, 7:22 PM.

Details

Summary

Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to buttons and improving the buttons, updating strings and more.

Test Plan

Open the Fonts KCM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Fri, Feb 8, 7:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 8, 7:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Fri, Feb 8, 7:22 PM
GB_2 updated this revision to Diff 51213.Fri, Feb 8, 7:29 PM

Change "Force fonts DPI" checkbox text to "Force font DPI"

ngraham accepted this revision.Fri, Feb 8, 7:33 PM
ngraham added a subscriber: ngraham.

No suggestions for improvement! I guess because this has already been discussed for weeks in the IRC channel. :)

This revision is now accepted and ready to land.Fri, Feb 8, 7:33 PM
GB_2 edited the summary of this revision. (Show Details)Fri, Feb 8, 7:35 PM
rooty accepted this revision.Fri, Feb 8, 7:48 PM

yeah we've been discussing this for weeks you've got my vote :D

ndavis added a subscriber: ndavis.Fri, Feb 8, 9:40 PM

I don't like the look of the | character between the font name and the font size. I think the existing "Noto Sans 10" format looked better, but I'm not going to formally request changes.

Personally my preference would be for the strings to be like this: 10 pt Noto Sans

ndavis added a comment.Fri, Feb 8, 9:46 PM

Personally my preference would be for the strings to be like this: 10 pt Noto Sans

That would be fine too since it reads like English. The | character makes it seem like we're mixing TUI with GUI.

ngraham requested changes to this revision.Fri, Feb 8, 9:49 PM

All right, let's do that. :)

This revision now requires changes to proceed.Fri, Feb 8, 9:49 PM
GB_2 added a comment.Fri, Feb 8, 10:41 PM

What about Noto Sans 10pt?

The other ordering is more English-like, but your suggestion would probably be fine too.

Please use more descriptive messages than "Improve the blahblah".
Practically every single commit aims to improve the product.

GB_2 added a comment.Sat, Feb 9, 11:33 AM

Please use more descriptive messages than "Improve the blahblah".
Practically every single commit aims to improve the product.

I added the word UI, what do you suggest as a title?
I can't think of anything better, because this changes many different things.

Perhaps "Modernize" would be a more specific word than "Improve"?

davidedmundson accepted this revision.Sat, Feb 9, 2:27 PM

Perhaps "Modernize" would be a more specific word than "Improve"?

Not really. There's nothing "modern" about putting an icon on a button.

adding "UI" helps clarify it's not behavioural changes. That'll do.

From a dev POV, ship it. But get a ship it from someone in VDG too for the string changes.

GB_2 retitled this revision from Improve the Fonts KCM UI to Improve the look of the Fonts KCM UI.Sat, Feb 9, 2:28 PM
GB_2 updated this revision to Diff 51274.Sat, Feb 9, 5:06 PM

Show pt after font size and remove seperator in the font preview. Also apply the KDE HIG even more.

GB_2 edited the summary of this revision. (Show Details)Sat, Feb 9, 5:06 PM
ngraham accepted this revision.Sat, Feb 9, 11:55 PM

Looks good to me!

This revision is now accepted and ready to land.Sat, Feb 9, 11:55 PM
This revision was automatically updated to reflect the committed changes.