Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to buttons and improving the buttons, updating strings and more.
Details
Details
- Reviewers
ngraham rooty davidedmundson - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
- Commits
- R119:9dac09af4a02: Improve the look of the Fonts KCM UI
Open the Fonts KCM.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
No suggestions for improvement! I guess because this has already been discussed for weeks in the IRC channel. :)
Comment Actions
I don't like the look of the | character between the font name and the font size. I think the existing "Noto Sans 10" format looked better, but I'm not going to formally request changes.
Comment Actions
That would be fine too since it reads like English. The | character makes it seem like we're mixing TUI with GUI.
Comment Actions
The other ordering is more English-like, but your suggestion would probably be fine too.
Comment Actions
Please use more descriptive messages than "Improve the blahblah".
Practically every single commit aims to improve the product.
Comment Actions
I added the word UI, what do you suggest as a title?
I can't think of anything better, because this changes many different things.
Comment Actions
Perhaps "Modernize" would be a more specific word than "Improve"?
Not really. There's nothing "modern" about putting an icon on a button.
adding "UI" helps clarify it's not behavioural changes. That'll do.
From a dev POV, ship it. But get a ship it from someone in VDG too for the string changes.
Comment Actions
Show pt after font size and remove seperator in the font preview. Also apply the KDE HIG even more.