cdb: First working version
ClosedPublic

Authored by patrickelectric on Fri, Feb 8, 6:35 PM.

Details

Summary

This patch introduces support to CDB, providing useful backtraces in bug tickets created through DrKonqi on windows.
CDB is normally used on windows to debug MSVC applications, this also will help us to create smaller deployment packages since everything will be MSVC compatible.

This is also based on lldb support.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
patrickelectric created this revision.Fri, Feb 8, 6:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 8, 6:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
patrickelectric requested review of this revision.Fri, Feb 8, 6:35 PM
  • msvc: Add cdb configuration
ngraham added a subscriber: ngraham.Fri, Feb 8, 8:30 PM

The title and summary sections need to describe what this patch does. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

patrickelectric added a comment.EditedFri, Feb 8, 9:14 PM

thank you @ngraham, but this is not ready to review yet.
But be free to review D18801 and D18802

Then it should not have been submitted yet, or it should have [WIP] at the beginning of the title. :)

patrickelectric retitled this revision from msvc: First commit to [WIP] msvc: First commit.Fri, Feb 8, 9:16 PM

Correct and initial implementation

patrickelectric retitled this revision from [WIP] msvc: First commit to cdb: First working version.Tue, Feb 12, 3:00 PM

This is a screenshot of drkonqi on windows, it was built with craft and integrated with a WIP project.

tcanabrava requested changes to this revision.Tue, Feb 12, 3:08 PM
tcanabrava added inline comments.
src/parser/backtraceparsercdb.h
32

remove virtual, override.

35

remove virtual, override.

This revision now requires changes to proceed.Tue, Feb 12, 3:08 PM

remove virtual, override.

patrickelectric marked 2 inline comments as done.EditedTue, Feb 12, 3:11 PM

Remove virtual

patrickelectric edited the summary of this revision. (Show Details)Tue, Feb 12, 3:17 PM
patrickelectric edited the summary of this revision. (Show Details)Tue, Feb 12, 3:22 PM
tcanabrava added inline comments.Wed, Feb 13, 4:15 PM
src/parser/backtraceparsercdb.h
32

still missing the override.

35

still missing the override.

Add missing override

tcanabrava accepted this revision.Fri, Feb 15, 1:45 PM
This revision is now accepted and ready to land.Fri, Feb 15, 1:45 PM
This revision was automatically updated to reflect the committed changes.
patrickelectric marked 2 inline comments as done.
cfeck added a subscriber: cfeck.Fri, Feb 15, 2:10 PM

This patch introduces support to CDB, providing useful backtraces in bug tickets created through DrKonqi on windows.

Just noticed this. This will help a lot to get better crash reports for our Windows ports. Thanks!