Fix opening toolbox button
ClosedPublic

Authored by broulik on Fri, Feb 8, 10:07 AM.

Details

Summary

Dialog no longer alters the mainItem's visiblity, so this codepath failed.
It should have used Dialog's visiblity from the beginning anyway.

Test Plan

5.12?

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Fri, Feb 8, 10:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 8, 10:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Fri, Feb 8, 10:07 AM
lbeltrame accepted this revision.Fri, Feb 8, 10:10 AM
lbeltrame added a subscriber: lbeltrame.

Works. No side effects.

This revision is now accepted and ready to land.Fri, Feb 8, 10:10 AM

That framework change is released tomorrow, right? Is it worth reverting?
Including this, that's at least the second regression it's caused, which makes me worry there's even more we haven't found.

It should have used Dialog's visiblity from the beginning anyway.

It should, so still ship this.

This revision was automatically updated to reflect the committed changes.