Differential D18831

[sddm-theme] Use more precise labels for "Different User"
ClosedPublic
Actions

Authored by filipf on Feb 7 2019, 10:09 PM.

Details

Reviewers
ngraham
hein
Group Reviewers
Plasma
VDG
Commits
R120:5bdd05f27cf5: [sddm-theme] Use more precise labels for "Different User"
Summary

The "Different User" action button label is wrong. The respective button switches to a screen where usernames are manually inputted. The patch proposes a better label and also renames the label in this manual input screen.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Feb 7 2019, 10:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 7 2019, 10:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Feb 7 2019, 10:09 PM
filipf edited the summary of this revision. (Show Details)Feb 7 2019, 10:10 PM
filipf added reviewers: ngraham, Plasma, VDG.
ngraham added a comment.Feb 7 2019, 10:16 PM

"Input" isn't a very common verb to start a sentence with in English. How about just "Type User" or "Type Username"

rooty added a subscriber: rooty.Feb 7 2019, 10:21 PM
In D18831#407445, @ngraham wrote:

"Input" isn't a very common verb to start a sentence with in English. How about just "Type User" or "Type Username"

Type User might be better (shorter, doesn't spill over into a new line)

filipf updated this revision to Diff 51136.Feb 7 2019, 10:29 PM

Better label, change the Type User screen label as well

filipf retitled this revision from [sddm-theme] Rename "Different User" to "Input User" to [sddm-theme] Use more precise labels for "Different User".Feb 7 2019, 10:31 PM
filipf edited the summary of this revision. (Show Details)Feb 7 2019, 10:34 PM
hein accepted this revision.Feb 7 2019, 10:52 PM
This revision is now accepted and ready to land.Feb 7 2019, 10:52 PM
rooty added a comment.Feb 7 2019, 10:52 PM

Also I think the title of the log in by typing screen should follow title capitalization, hence:
"Type in Username and Password"

filipf updated this revision to Diff 51137.Feb 7 2019, 10:59 PM

use title case for the second label

rooty added a comment.Feb 7 2019, 11:04 PM

perfect I think it's ready to land now

ngraham accepted this revision.Feb 7 2019, 11:20 PM

All right, let's do it!

Closed by commit R120:5bdd05f27cf5: [sddm-theme] Use more precise labels for "Different User" (authored by filipf, committed by rooty). · Explain WhyFeb 7 2019, 11:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msddm-theme/Main.qml (4 lines)

Diff 51142

View Options

sddm-theme/Main.qml

Loading...