Differential D18812

Disables use of Always Use Template in the New File window
ClosedPublic
Actions

Authored by tymond on Feb 7 2019, 1:50 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:c027f26d134d: BUG:399796 Disables use of Always Use Template in the New File window
Summary

When new custom template is created, Always Use Template and Full Template Path
are both set to the new template. When a template is being used, only
Full Template Path is set to the last used template. When highlighting
the template as default to use in New File window, Krita first uses
Always Use Template, then Full Template Path, then just first template
in the alphabetical order. To make sure the last used template is always the one
that Krita highlights, Always Use Template needs not to be considered.
This commit removes the mention of Always Use Template
in the New File window's code.

BUG: 399796

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
tymond created this revision.Feb 7 2019, 1:50 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptFeb 7 2019, 1:50 PM
tymond requested review of this revision.Feb 7 2019, 1:50 PM
rempt accepted this revision.Feb 8 2019, 11:36 AM
rempt added a subscriber: rempt.

We probably should rip out the alwaysusetemplate stuff completely: afair, we don't even expose it in the gui anymore. It's an old koffice-ism

This revision is now accepted and ready to land.Feb 8 2019, 11:36 AM
woltherav added a subscriber: woltherav.Feb 16 2019, 2:27 PM

Was this pushed yet? If not, I can push it, but need a firstname lastname and email adress so it gets credited properly.

tymond added a comment.Feb 16 2019, 5:05 PM

As far as I know, it's not pushed yet. My credentials:

Agata Cacko tamtamy.tymona (o) gmail.com

Regarding the AlwaysUseTemplate: yes, it was the last trace of it in the UI. The system is, however, both complex and actually working if you enable two related checkboxes, that's why I haven't removed it, just disabled the last part. I can remove everything though.

Closed by commit R37:c027f26d134d: BUG:399796 Disables use of Always Use Template in the New File window (authored by tymond, committed by woltherav). · Explain WhyFeb 17 2019, 2:59 PM
This revision was automatically updated to reflect the committed changes.
woltherav added a comment.Feb 17 2019, 3:00 PM

Alright, keep track of the number of patches that get pushed, at 3 we will entrust you with KDE commit access :)

Revision Contents
Changeset List

PathPackages
Mlibs/ui/KisTemplatesPane.cpp (25 lines)

Diff 51097

View Options

libs/ui/KisTemplatesPane.cpp

Loading...