Differential D18808

[backends/hwcomposer] Port to AbstractOutput
ClosedPublic
Actions

Authored by davidedmundson on Feb 7 2019, 12:12 PM.

Details

Reviewers

romangg

Group Reviewers

KWin

Commits

R108:062dfefafe06: [platforms/hwcomposer] Port to AbstractOutput

Summary

This gives us XdgOutput support a requirement now that wayland server
reports that we support it and Qt5.12 then expects it to be sent.

It also provides an easy starting point for supporting wayland scaling
and a slight step towards multi-output.

Test Plan

Ran on phone. Got output. Turning screen on and off works.
The double tap doesn't work great, but that was true before
(via bshah's hack to build on the current state)

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Feb 7 2019, 12:12 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 7 2019, 12:12 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Feb 7 2019, 12:12 PM

Harbormaster completed remote builds in B7974: Diff 51086.Feb 7 2019, 12:12 PM

zzag added a subscriber: zzag.Feb 7 2019, 12:36 PM

zzag added inline comments.

plugins/platforms/hwcomposer/hwcomposer_backend.cpp
38–39	kf includes go before qt includes.
466–468	: AbstractOutput() , m_device
plugins/platforms/hwcomposer/hwcomposer_backend.h
50	Style.

Please capitalize the subject line,.

whitespace

Harbormaster completed remote builds in B7978: Diff 51091.Feb 7 2019, 12:48 PM

davidedmundson added a dependent revision: D18810: [platforms/hwcomposer] Add scaling support.Feb 7 2019, 12:56 PM

remove a stray newline

Harbormaster completed remote builds in B7981: Diff 51095.Feb 7 2019, 12:59 PM

We have kinda weird(?) git subject line style guidelines, but... I think this revision( and D18810) should have "[platforms/hwcomposer]" prefix.

davidedmundson retitled this revision from [plugins/backends/hwcomposer] port to AbstractOutput to [backends/hwcomposer] port to AbstractOutput.Feb 7 2019, 1:51 PM

davidedmundson retitled this revision from [backends/hwcomposer] port to AbstractOutput to [backends/hwcomposer] Port to AbstractOutput.Feb 7 2019, 1:59 PM

nicolasfella added a subscriber: nicolasfella.Feb 8 2019, 11:49 AM

Code looks fine. Scrolling through the git history, as Vlad said, the prefix should be [platforms/hwcomposer].

This revision is now accepted and ready to land.Feb 8 2019, 1:01 PM

Closed by commit R108:062dfefafe06: [platforms/hwcomposer] Port to AbstractOutput (authored by davidedmundson). · Explain WhyFeb 20 2019, 1:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/hwcomposer/hwcomposer_backend.h (43 lines)
M			plugins/platforms/hwcomposer/hwcomposer_backend.cpp (169 lines)
M			plugins/platforms/hwcomposer/screens_hwcomposer.h (8 lines)
M			plugins/platforms/hwcomposer/screens_hwcomposer.cpp (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51086	8eaf40c		Feb 7 2019, 12:12 PM	★	★
Diff 2	51091	8eaf40c	whitespace	Feb 7 2019, 12:48 PM	★	★
Diff 3	51095	261e3a7	remove a stray newline	Feb 7 2019, 12:59 PM	★	★
Diff 4	52140	3cdea2f	R108:062dfefafe06629117abf37b68ef59964fbb9654	Feb 20 2019, 1:20 PM	★	★