[backends/hwcomposer] Port to AbstractOutput
AcceptedPublic

Authored by davidedmundson on Thu, Feb 7, 12:12 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Summary

This gives us XdgOutput support a requirement now that wayland server
reports that we support it and Qt5.12 then expects it to be sent.

It also provides an easy starting point for supporting wayland scaling
and a slight step towards multi-output.

Test Plan

Ran on phone. Got output. Turning screen on and off works.
The double tap doesn't work great, but that was true before
(via bshah's hack to build on the current state)

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7981
Build 7999: arc lint + arc unit
davidedmundson created this revision.Thu, Feb 7, 12:12 PM
Restricted Application added a project: KWin. · View Herald TranscriptThu, Feb 7, 12:12 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Thu, Feb 7, 12:12 PM
zzag added a subscriber: zzag.Thu, Feb 7, 12:36 PM
zzag added inline comments.
plugins/platforms/hwcomposer/hwcomposer_backend.cpp
38–39

kf includes go before qt includes.

466–468
: AbstractOutput()
, m_device
plugins/platforms/hwcomposer/hwcomposer_backend.h
50

Style.

zzag added a comment.Thu, Feb 7, 12:36 PM

Please capitalize the subject line,.

remove a stray newline

zzag added a comment.EditedThu, Feb 7, 1:04 PM

We have kinda weird(?) git subject line style guidelines, but... I think this revision( and D18810) should have "[platforms/hwcomposer]" prefix.

davidedmundson retitled this revision from [plugins/backends/hwcomposer] port to AbstractOutput to [backends/hwcomposer] port to AbstractOutput.Thu, Feb 7, 1:51 PM
davidedmundson retitled this revision from [backends/hwcomposer] port to AbstractOutput to [backends/hwcomposer] Port to AbstractOutput.Thu, Feb 7, 1:59 PM
romangg accepted this revision.Fri, Feb 8, 1:01 PM
romangg added a subscriber: romangg.

Code looks fine. Scrolling through the git history, as Vlad said, the prefix should be [platforms/hwcomposer].

This revision is now accepted and ready to land.Fri, Feb 8, 1:01 PM