Differential D18803

[effects/screenedge] Use correct blend function
ClosedPublic
Actions

Authored by zzag on Feb 7 2019, 12:05 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:bdddf4daf2d8: [effects/screenedge] Use correct blend function
R108:16a2799b3a25: Merge branch 'Plasma/5.15'
Summary

Glow textures already have the red, green, and blue channels
premultiplied by the alpha component (because of QImage), thus we can't
use GL_SRC_ALPHA for sfactor in glBlendFunc.

BUG: 403570

Test Plan

Before:

After:

Diff Detail

Repository
R108 KWin
Branch
screenedge-correct-blend-func
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7967
Build 7985: arc lint + arc unit
zzag created this revision.Feb 7 2019, 12:05 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 7 2019, 12:05 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 7 2019, 12:05 AM
davidedmundson accepted this revision.Feb 7 2019, 12:09 AM
This revision is now accepted and ready to land.Feb 7 2019, 12:09 AM
Closed by commit R108:bdddf4daf2d8: [effects/screenedge] Use correct blend function (authored by zzag). · Explain WhyFeb 7 2019, 12:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51069

View Options

effects/screenedge/screenedgeeffect.cpp

Loading...