[breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg
ClosedPublic

Authored by rooty on Feb 6 2019, 7:23 PM.

Details

Summary

This patch adds 16 px SVGs of gnumeric-font.svg and creates a symbolic link for both the 16 px and 24 px versions (font.svg),

Diff Detail

Repository
R266 Breeze Icons
Branch
gnumeric-font-16px (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7954
Build 7972: arc lint + arc unit
rooty created this revision.Feb 6 2019, 7:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 6 2019, 7:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
rooty requested review of this revision.Feb 6 2019, 7:23 PM
ngraham added a reviewer: VDG.Feb 6 2019, 7:25 PM
ngraham added subscribers: ndavis, ngraham.

Ask and ye shall receive, eh!?

To channel @ndavis, it would be nice if you could run these through an optimizer. :)

rooty retitled this revision from [breeze-icons] Add 16px versions of gnumeric-font and link gnumeric font to font.svg to [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg.Feb 6 2019, 7:25 PM
rooty edited the summary of this revision. (Show Details)

Ask and ye shall receive, eh!?

To channel @ndavis, it would be nice if you could run these through an optimizer. :)

Haha it just took me a while to figure out how to resize them... Inkscape truly is the gift that keeps on giving

ndavis added a comment.Feb 7 2019, 2:24 AM

Hmm somehow I missed this. Here's a way to optimize it with a utility that's available in most distro repos (scour, python-scour):

scour input.svg output.svg --enable-viewboxing --enable-id-stripping --enable-comment-stripping --shorten-ids --remove-descriptive-elements --create-groups --strip-xml-space --strip-xml-prolog --nindent=4
mv output.svg input.svg

I only use --nindent=4 because this SVG is supposed to have embedded stylesheets, so it's good to keep it easy to read. For icons without embedded stylesheets, I would use --indent=none --no-line-breaks.

ndavis added inline comments.Feb 7 2019, 2:27 AM
icons-dark/actions/16/gnumeric-font.svg
60

Delete color:#eff0f1; here. This hardcodes the color and makes the stylesheet not work.

icons/actions/16/gnumeric-font.svg
60

Delete color:#232629;

rooty added a comment.Feb 7 2019, 6:51 AM

Wow thanks @ndavis, scour shrinks it even more than svgcleaner does and doesn't enforce a fill color.

rooty updated this revision to Diff 51074.Feb 7 2019, 6:53 AM

Optimize and remove hardcoded colors

ndavis added a comment.Feb 7 2019, 6:53 AM

Wow thanks @ndavis, scour shrinks it even more than svgcleaner does

Not in my experience, but I'm glad it works well for you.

rooty marked 2 inline comments as done.Feb 7 2019, 7:06 AM
ndavis added a comment.Feb 7 2019, 7:36 AM

Now that I've had a look at the icon, it's not aligned with the pixel grid. The original icon wasn't very well aligned either, but at least the top and bottom were. Shrinking down from one monochrome size to another without adjusting to fit the grid generally doesn't work very well.

Have a look at format-font-size-more

You only need to copy the A. You can do that by breaking apart the path (Path->Break Apart, Ctrl+Shift+k), then using Path->Difference (Ctrl+-) with the triangle in the middle of the A and the A itself selected to get the triangular hole back.

To be honest, the original icon isn't that great, but I don't have any better ideas and I won't blame you for not wanting to come up with something brand new.

ndavis requested changes to this revision.Feb 7 2019, 7:36 AM
This revision now requires changes to proceed.Feb 7 2019, 7:36 AM
rooty added a comment.Feb 7 2019, 8:39 AM
This comment was removed by rooty.
rooty added a comment.Feb 7 2019, 8:49 AM

Is this ok? I had to stretch it out a lil bit at the top and bottom

In my previous comment I just moved it and I realized it had four pixels above and three below it...

GB_2 added a subscriber: GB_2.EditedFeb 7 2019, 12:14 PM

@rooty just copy a different 16px font icon like gtk-select-font and remove the other things than the A and align it in the horizontal center.

rooty updated this revision to Diff 51092.Feb 7 2019, 12:55 PM

Implement GB_2's suggestion and use gtk-select-font as template for new icons

GB_2 accepted this revision.Feb 7 2019, 3:26 PM

Great!

ngraham accepted this revision.Feb 7 2019, 3:31 PM

+1 shipit!

ndavis accepted this revision.Feb 7 2019, 4:25 PM
This revision is now accepted and ready to land.Feb 7 2019, 4:25 PM
rooty closed this revision.Feb 7 2019, 4:36 PM