Differential D18791

QuotedPrintableDecoder::decode: return false on error instead of asserting
ClosedPublic
Actions

Authored by aacid on Feb 6 2019, 6:55 PM.

Details

Reviewers
None
Commits
R270:26cee94dc4f3: QuotedPrintableDecoder::decode: return false on error instead of asserting
Summary

let's the fuzzying process continue forward

Diff Detail

Repository
R270 KCodecs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Feb 6 2019, 6:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 6 2019, 6:55 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Feb 6 2019, 6:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2019, 7:05 PM
Closed by commit R270:26cee94dc4f3: QuotedPrintableDecoder::decode: return false on error instead of asserting (authored by aacid). · Explain Why
This revision was automatically updated to reflect the committed changes.
aacid added a comment.Feb 6 2019, 7:05 PM

Noooooooooooooooo, i commited this by mistake.

Can anyone still please review and tell me if it's wrong and i'll revert?

vkrause added a comment.Feb 6 2019, 7:14 PM

This looks ok to me. The documentation doesn't really specify what should happen on error esp. regarding the return value, but asserting is clearly the wrong approach.

Revision Contents
Changeset List

PathPackages
Msrc/kcodecsqp.cpp (3 lines)

Diff 51049

View Options

src/kcodecsqp.cpp

Loading...