Add support for loading and using an icontheme in a RCC file automatically.
ClosedPublic

Authored by dfaure on Jun 14 2016, 8:41 PM.

Details

Summary

This generalizes the solution currently duplicated in kate and kdevelop,
to all apps.
The intended use case is e.g. BINDIR/data/icontheme.rcc on Windows.

Test Plan

Concept patch tested on Windows by Kåre Särs, this implementation tested by the unittest

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure updated this revision to Diff 4476.Jun 14 2016, 8:41 PM
dfaure retitled this revision from to Add support for loading and using an icontheme in a RCC file automatically..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added reviewers: cullmann, sars.
cullmann edited edge metadata.Jun 14 2016, 9:32 PM

Using DataLocation and with cleaned up config not setting a theme name, this works ;)

dfaure updated this revision to Diff 4478.Jun 14 2016, 10:19 PM
dfaure edited edge metadata.

Pass icon theme name to KIconTheme so that direct KIconLoader usage still works.

(e.g. from KToolBar, which queries for icon sizes)

Fix runtime warning about "oxygen not found" (breeze inherits hicolor).

dfaure updated this revision to Diff 4479.Jun 14 2016, 10:26 PM

Fix "hicolor not found" warning by integrating the hicolor index.theme.

The latest versions allows me to have icons + no warnings on Mac OS.

I think tomorrow one should try this out on Windows, too (I will remove the boilerplate code from kate) and if that is nice, there, too, this should go in.

Thanks for the fix!

sars accepted this revision.Jun 15 2016, 8:32 AM
sars edited edge metadata.

Works nicely here :) Icons + no icon warnings

This revision is now accepted and ready to land.Jun 15 2016, 8:32 AM
cullmann accepted this revision.Jun 15 2016, 8:32 AM
cullmann edited edge metadata.

As Windows works, too, I am happy ;=)

dfaure closed this revision.Jun 15 2016, 9:30 AM