In certain cases we might end up with invalid results being returned by a KNS source. These entries should be considered undesirable, and consequently filtered out.
Details
Details
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
libdiscover/backends/KNSBackend/KNSBackend.cpp | ||
---|---|---|
213 | first arg should be filtered. |
libdiscover/backends/KNSBackend/KNSBackend.cpp | ||
---|---|---|
213 | Oh dear! Yes, it should. |
Comment Actions
Indeed, that would want to be looked at. Essentially, it just forwards the result of the list job from Attica, which in the case of empty results are just... also empty EntryInternal instances. Basically, we just never had a server which did things like that before, so we're now finding some slightly odd bugs that've always been there, caused by little assumptions about the way the server works ;) Not entirely sure if the fix wants to be in Attica or in KNewStuff... Probably Attica, though.
This comment was removed by ngraham.