Differential D18754

[Look and Feel KCM] Write schemeName last
ClosedPublic
Actions

Authored by broulik on Feb 5 2019, 11:13 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:bbf848a92a37: [Look and Feel KCM] Write schemeName last
Summary

We copy the .colors file's contents into kdeglobals and I have seen many of them containing bogus

[General]
ColorScheme=Some Other Scheme

which makes no sense. Ensure the ColorScheme that ends up in kdeglobals is the scheme defined by the look and feel package.

BUG: 403774

Test Plan

Downloaded "Modern" lnf from kde store, applied it and system changed to a dark color scheme.
Previously it would write "Breeze Dark" from its colors file to kdeglobals, now it is correctly "BreezeDarcBlue"
Changed to Breeze Dark and it would no longer complain about a not installed theme
This also obsoletes D18752 as now the correct scheme name is always present in kdeglobals

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 5 2019, 11:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2019, 11:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 5 2019, 11:13 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Feb 5 2019, 11:15 AM

Is it worth putting this in 5.15?

This revision is now accepted and ready to land.Feb 5 2019, 11:15 AM
Closed by commit R119:bbf848a92a37: [Look and Feel KCM] Write schemeName last (authored by broulik). · Explain WhyFeb 5 2019, 11:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/lookandfeel/kcm.cpp (5 lines)

Diff 50930

View Options

kcms/lookandfeel/kcm.cpp

Loading...