Differential D18753

[kcms/keys] Fix double margin
ClosedPublic
Actions

Authored by davidedmundson on Feb 5 2019, 11:03 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:004ce594feff: [kcms/keys] Fix double margin
Summary

A widget should expand to the edge of the widget. i.e a QLineEdit covers
the size of the whole line edit. It's up to the parent layout to then
provide margins.

The same rule applies to complex widgets which are a layout of other
widgets.

Test Plan

Frame lines up with bottom buttons

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7906
Build 7924: arc lint + arc unit
davidedmundson created this revision.Feb 5 2019, 11:03 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2019, 11:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 5 2019, 11:03 AM
broulik accepted this revision.Feb 5 2019, 2:26 PM
This revision is now accepted and ready to land.Feb 5 2019, 2:26 PM
Closed by commit R119:004ce594feff: [kcms/keys] Fix double margin (authored by davidedmundson). · Explain WhyFeb 5 2019, 2:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/keys/kglobalshortcutseditor.ui (18 lines)

Diff 50928

View Options

kcms/keys/kglobalshortcutseditor.ui

Loading...