Also try untranslated theme name
AbandonedPublic

Authored by broulik on Feb 5 2019, 10:54 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Color scheme names can be translated (and have recently been) which is why the new KCM is built around color scheme file names.
However, other places, such as Look and feel package, especially third party ones, still rely on the color scheme name as key.
Also look for the untranslated name if a filename isn't found.

BUG: 403774

Test Plan

Changed to breeze dark look and feel which sets theme to "Breeze Dark", no longer get an error message because the file is actually "BreezeDark"

A LNF package can also ship its own fully custom color scheme that isn't system-wide installed, so perhaps this needs some additional changes later, such as "You are using 'whatever lnf package' which uses a custom color scheme.", instead of a warning/error message. (I knew that dumping all of that "Current" and "Default" logic would fall on my feet eventually :/)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 5 2019, 10:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2019, 10:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 5 2019, 10:54 AM
broulik edited the test plan for this revision. (Show Details)Feb 5 2019, 10:57 AM

Why do we ever need to use a translated version?

broulik abandoned this revision.Feb 5 2019, 11:15 AM

Superseded by D18754