Differential D18745

Fix connections' context menus position and parent
ClosedPublic
Actions

Authored by vpilo on Feb 5 2019, 8:16 AM.

Details

Reviewers
broulik
jgrulich
Commits
R116:5000fc973c6d: Fix connections' context menus position and parent
Summary

A connection's context menu now opens only from the main item, not from the expanded details;
this allows again copying the connection information (as per comments in D18504).

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vpilo created this revision.Feb 5 2019, 8:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2019, 8:16 AM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vpilo requested review of this revision.Feb 5 2019, 8:16 AM
jgrulich added a comment.Feb 5 2019, 8:24 AM

This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items.

vpilo added a comment.Feb 5 2019, 9:53 AM
In D18745#405458, @jgrulich wrote:

This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items.

Oh, looks like I didn't test the latest change for available connections, only for active ones. I'll check, thank you.

vpilo updated this revision to Diff 50971.Feb 5 2019, 5:09 PM

Reworked.

There already were lots of binding loops in this QML, stuff for another change

vpilo edited the summary of this revision. (Show Details)Feb 5 2019, 5:11 PM
jgrulich accepted this revision.Feb 6 2019, 6:47 AM

Seems to work. Thanks.

This revision is now accepted and ready to land.Feb 6 2019, 6:47 AM
Closed by commit R116:5000fc973c6d: Fix connections' context menus position and parent (authored by vpilo). · Explain WhyFeb 6 2019, 7:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51018

View Options

applet/contents/ui/ConnectionItem.qml

Loading...