Convert old style to Qt5 style connection
ClosedPublic
Actions

Authored by andreagenor on Feb 5 2019, 3:35 AM.

Details

Reviewers

Commits

R374:f561f6d58b71: Convert old style to Qt5 style connection

Summary

Almost all old-style code was converted. There are some residual code that needs more attention because he has interdependencies that need to be
solved before conversions

Diff Detail

Repository

R374 KolourPaint

Branch

dev/convert-connect

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7891
Build 7909: arc lint + arc unit

andreagenor requested review of this revision.Feb 5 2019, 3:35 AM

andreagenor created this revision.

Harbormaster completed remote builds in B7891: Diff 50902.Feb 5 2019, 3:35 AM

andreagenor added a reviewer: tcanabrava.Feb 5 2019, 3:36 AM

tcanabrava accepted this revision.Feb 5 2019, 9:07 AM

This revision is now accepted and ready to land.Feb 5 2019, 9:07 AM

Closed by commit R374:f561f6d58b71: Convert old style to Qt5 style connection (authored by andreagenor, committed by tcanabrava). · Explain WhyFeb 5 2019, 10:35 AM

This revision was automatically updated to reflect the committed changes.

This breaks the font tool, can no longer change font style or font size

This revision is now accepted and ready to land.Feb 10 2019, 5:15 PM

In D18741#409312, @broulik wrote:

This breaks the font tool, can no longer change font style or font size

I'll take a look

andreagenor mentioned this in D18927: Changed to use correct object signal.Feb 11 2019, 3:48 PM

tcanabrava mentioned this in R374:f766486c1947: Changed to use correct object signal.Feb 12 2019, 10:18 AM

already merged and a followup was also merged fixing the issues related by @broulik

Revision Contents
Changeset List

			Path	Packages
M			commands/kpCommandHistoryBase.cpp (13 lines)
M			commands/tools/selection/kpToolSelectionResizeScaleCommand.h (5 lines)
M			commands/tools/selection/kpToolSelectionResizeScaleCommand.cpp (12 lines)
M			dialogs/imagelib/effects/kpEffectsDialog.cpp (22 lines)
M			dialogs/imagelib/kpDocumentMetaInfoDialog.cpp (25 lines)
M			dialogs/imagelib/transforms/kpTransformPreviewDialog.cpp (12 lines)
M			dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp (45 lines)
M			dialogs/imagelib/transforms/kpTransformRotateDialog.cpp (35 lines)
M			dialogs/imagelib/transforms/kpTransformSkewDialog.cpp (11 lines)
M			dialogs/kpColorSimilarityDialog.cpp (16 lines)
M			dialogs/kpDocumentSaveOptionsPreviewDialog.cpp (4 lines)
M			document/kpDocument.h (1 line)
M			document/kpDocument.cpp (17 lines)
M			document/kpDocument_Selection.cpp (4 lines)
M			kpThumbnail.cpp (18 lines)
M			kpViewScrollableContainer.h (3 lines)
M			kpViewScrollableContainer.cpp (69 lines)
M			lgpl/generic/widgets/kpColorCellsBase.h (2 lines)
M			lgpl/generic/widgets/kpColorCellsBase.cpp (4 lines)
M			mainWindow/kpMainWindow.cpp (109 lines)
M			mainWindow/kpMainWindow_Colors.cpp (39 lines)
M			mainWindow/kpMainWindow_Edit.cpp (18 lines)
M			mainWindow/kpMainWindow_File.cpp (21 lines)
M			mainWindow/kpMainWindow_Image.cpp (32 lines)
M			mainWindow/kpMainWindow_Settings.cpp (4 lines)
M			mainWindow/kpMainWindow_Text.cpp (24 lines)
M			mainWindow/kpMainWindow_Tools.cpp (144 lines)
M			mainWindow/kpMainWindow_View.cpp (4 lines)
M			mainWindow/kpMainWindow_View_Thumbnail.cpp (24 lines)
M			mainWindow/kpMainWindow_View_Zoom.cpp (4 lines)
M			scan/sanedialog.cpp (4 lines)
M			tools/flow/kpToolFlowBase.cpp (16 lines)
M			tools/flow/kpToolSpraycan.cpp (11 lines)
M			tools/kpTool.h (3 lines)
M			tools/kpTool.cpp (2 lines)
M			tools/kpToolAction.cpp (5 lines)
M			tools/kpTool_UserNotifications.cpp (2 lines)
M			tools/polygonal/kpToolPolygon.cpp (12 lines)
M			tools/polygonal/kpToolPolygonalBase.cpp (10 lines)
M			tools/rectangular/kpToolRectangularBase.cpp (24 lines)
M			tools/selection/kpAbstractSelectionTool.cpp (10 lines)
M			tools/selection/kpAbstractSelectionTool_Create.cpp (4 lines)
M			tools/selection/kpAbstractSelectionTool_Move.cpp (4 lines)
M			views/kpUnzoomedThumbnailView.cpp (6 lines)
M			views/kpView.cpp (66 lines)
M			views/manager/kpViewManager.h (3 lines)
M			views/manager/kpViewManager_TextCursor.cpp (3 lines)
M			views/manager/kpViewManager_ViewUpdates.cpp (15 lines)
M			widgets/colorSimilarity/kpColorSimilarityToolBarItem.cpp (7 lines)
M			widgets/imagelib/effects/kpEffectBalanceWidget.cpp (46 lines)
M			widgets/imagelib/effects/kpEffectBlurSharpenWidget.cpp (8 lines)
M			widgets/imagelib/effects/kpEffectEmbossWidget.cpp (8 lines)
M			widgets/imagelib/effects/kpEffectFlattenWidget.cpp (13 lines)
M			widgets/imagelib/effects/kpEffectHSVWidget.cpp (12 lines)
M			widgets/imagelib/effects/kpEffectInvertWidget.cpp (20 lines)
M			widgets/imagelib/effects/kpEffectReduceColorsWidget.cpp (24 lines)
M			widgets/imagelib/effects/kpEffectToneEnhanceWidget.cpp (8 lines)
M			widgets/kpColorCells.cpp (13 lines)
M			widgets/kpColorPalette.cpp (18 lines)
M			widgets/kpDocumentSaveOptionsWidget.cpp (43 lines)
M			widgets/toolbars/kpColorToolBar.cpp (47 lines)
M			widgets/toolbars/kpToolToolBar.cpp (28 lines)