Differential D18740

[wayland] Set output scale when creating new OutputInterface instances
AbandonedPublic
Actions

Authored by davidedmundson on Feb 5 2019, 12:11 AM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

AbstractOuput::setScale had an effect on existing outputs, but calling
setScale before setEnabled(which creates the OutputInterface) would not
have worked.

Test Plan

Found in review of another change
Doesn't seem to have any practical impact due to way code happens to be written currently

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7890
Build 7908: arc lint + arc unit
davidedmundson created this revision.Feb 5 2019, 12:11 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2019, 12:11 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Feb 5 2019, 12:11 AM
zzag added a subscriber: zzag.Feb 5 2019, 2:49 PM

Out of curiosity: should we set global position as well?

davidedmundson planned changes to this revision.Feb 5 2019, 3:34 PM

Yeah, and now you mention it the entirety of the xdgOutput setting is missing on construction too.

It's all a bit of a mess, so I'm going to see if I can change it so waylandOutput object has the same lifespan as m_waylandOutputDevice and we just call create/destroy as appropriate to change what the clients bind to.
It would really clear all this code up.

davidedmundson abandoned this revision.Nov 30 2019, 6:26 PM

Revision Contents
Changeset List

PathPackages
Mabstract_output.cpp (1 line)

Diff 50898

View Options

abstract_output.cpp

Loading...